[Webkit-unassigned] [Bug 49835] Ignore reference files which will be used by reftests when collecting test cases.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49835





--- Comment #4 from Shinichiro Hamaji <hamaji at chromium.org>  2010-11-19 15:17:44 PST ---
(From update of attachment 74426)
View in context: https://bugs.webkit.org/attachment.cgi?id=74426&action=review

Style nitpicks.

> WebKitTools/Scripts/webkitpy/layout_tests/port/test_files.py:122
> +    if any(filename.endswith(ignored_suffix) for ignored_suffix

I think a simple loop would be easier to read and not longer than this code:

for ignored_suffix in _ignored_suffixes:
  if filename.endwith(ignored_suffix):
    _log.warn(...
    return True
return False

> WebKitTools/Scripts/webkitpy/layout_tests/port/test_files.py:124
> +        _log.warn('Reftests is not suuperted yet. %s is ignored.', filename)

"Reftest is not" ?

> WebKitTools/Scripts/webkitpy/layout_tests/port/test_files.py:130
> +    """Return true if filename represents test cases we want to run a test

It would be better to have one-line summary on the top of docstring.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.