[Webkit-unassigned] [Bug 49802] [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49802





--- Comment #2 from Gavin Barraclough <barraclough at apple.com>  2010-11-19 15:05:31 PST ---
Hi Ossy,

This should be an easy fix, but there are a couple of options, and I'm not sure which way we prefer to resolve this.

We've deliberately made a change to remove the source snippet ("(evaluating 'target.document.body')" in this case) from from error messages in release builds, unless the developer extras are enabled (i.e. inspector support is turned on).  So these results match correctly match those a user would see, if the inspector is not showing.  So one valid resolution would be to say, these are the correct results for a release run of this test case, and we should just check in expected results matching these.

However in order to ensure we are still testing the correct generation of these errors when the inspector is up, we're now always enabling the developer extras from DRT (in Qt's case, we do so from DumpRenderTree/qt/DumpRenderTreeQt.cpp).  So an alternative resolution for this bug would be to explore why the developer extras are not be enabled when this test case is run, and change this (I'm guessing it's something to do with this being a http test...?).  I'm not sure this buys us much, since the correct generation of these error messages is already well covered by LayoutTests.

Any thoughts on a preferred solution?

cheers,
G.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.