[Webkit-unassigned] [Bug 49382] Spatial Navigation: issues with the node selection algorithm.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49382





--- Comment #32 from Antonio Gomes <tonikitoo at webkit.org>  2010-11-19 11:13:04 PST ---
(From update of attachment 74401)
View in context: https://bugs.webkit.org/attachment.cgi?id=74401&action=review

> WebCore/page/FocusController.cpp:712
> +        if (!navigateInContainer(frameElement->contentFrame()->document(), rect, direction, event))
> +            // The new frame had nothing interesting, need to find another candidate.
> +            return navigateInContainer(container, nodeRectInAbsoluteCoordinates(focusCandidate.node, true), direction, event);

Please lets fix this before landing :)

One-line control clauses should not use braces unless comments are included or a single statement spans multiple lines.
Right:

if (condition) {
    // Some comment
    doIt();
}

Wrong:

if (condition)
    // Some comment
    doIt();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.