[Webkit-unassigned] [Bug 49778] Add USE(CHROMIUM_NET)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49778





--- Comment #6 from William Chan <willchan at chromium.org>  2010-11-19 09:39:21 PST ---
(In reply to comment #5)
> Why do we need another flag as opposed to just using PLATFORM(CHROMIUM)? It feels like another flag is only needed if you would choose CHROMIUM_NET independently from PLATFORM(CHROMIUM).

I am ill-equipped to justify this, due to my lack of WebKit knowledge.  I asked abarth how to implement my change for preload scanning and he suggested a USE macro.  If PLATFORM is the way to go, I'm happy to use that instead.  I will note that the Android browser (which I believe is the Android port in the webkit tree, although I'm not totally sure) uses the Chromium network stack.  So if it doesn't/shouldn't use PLATFORM(CHROMIUM), then perhaps USE is more appropriate here.  But I don't particularly care.

> 
> Re description: In general, the ChangeLog is the description.

Cool, great.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.