[Webkit-unassigned] [Bug 49748] [Qt] Compile with QT_NO_SCRIPT

Fri Nov 19 08:54:03 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=49748

Laszlo Gombos <laszlo.1.gombos at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74257|review?                     |review-
               Flag|                            |

--- Comment #3 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2010-11-19 08:54:03 PST ---
(From update of attachment 74257)
I do not think we can accept changes (with no proper build guards) that are relying on an unapproved/unreleased version of Qt API. We might be able to revisit this after the underlying Qt API is released.

In addition we have plans to unify the QtScript engine with the engine used by QtWebKit. Once these plans realize maintaining the QT_NO_SCRIPT configuration for QtWebKit will no longer make sense. 

Can you perhaps maintain these changes on your private branch instead of upstreaming them to the trunk ? 

r- as with our current processing, this commit would break the build.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.