[Webkit-unassigned] [Bug 49735] [Chromium] Introduce wrapper types for WebCore::GeolocationError, WebCore::GeolocationPosition, WebCore::GeolocationController

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49735


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74382|review?                     |review-
               Flag|                            |




--- Comment #2 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-11-19 08:43:36 PST ---
(From update of attachment 74382)
View in context: https://bugs.webkit.org/attachment.cgi?id=74382&action=review

> WebKit/chromium/public/WebGeolocationController.h:59
> +    WebCore::GeolocationController* m_controller;

what prevents the GeolocationController object from being destroyed before the WebGeolocationController?
how do you avoid memory errors in that case?

this seems error prone.

> WebKit/chromium/public/WebGeolocationError.h:38
> +class WebGeolocationError {

GeolocationError is reference counted, so it seems like you should implement
WebGeolocationError as a simple wrapper (like WebNode).

Use WebPrivatePtr<WebCore::GeolocationError> as your sole member variable.

> WebKit/chromium/public/WebGeolocationPosition.h:88
> +    void copyFrom(const WebCore::GeolocationPosition&);

GeolocationPosition is reference counted, so it seems like you should implement
WebGeolocationPosition as a simple wrapper (like WebNode).

Use WebPrivatePtr<WebCore::GeolocationPosition> as your sole member variable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.