[Webkit-unassigned] [Bug 49258] Implement Mocks for Client-based Geolocation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49258





--- Comment #5 from John Knottenbelt <jknotten at chromium.org>  2010-11-19 08:03:05 PST ---
(In reply to comment #4)
> I still think that having mock objects in WebCore is a strategically wrong approach.

For those who are not familiar with the thread on webkit-dev, here is a link
http://www.mail-archive.com/webkit-dev@lists.webkit.org/msg12162.html 

After all embedders have switched to using client-based geolocation ( https://bugs.webkit.org/show_bug.cgi?id=40373 ), we will be able to remove WebCore/platform/mock/GeolocationServiceMock.cpp altogther, so the net result will be to replace GeolocationServiceMock with GeolocationClientMock. 

As mentioned in the thread, I do think it is a good idea for the mocks to be compiled out of WebCore in production code. I have created bug https://bugs.webkit.org/show_bug.cgi?id=49806 and will raise this topic for discussion on webkit-dev when I come to look at it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.