[Webkit-unassigned] [Bug 49799] createImageBuffer fail should be handled in the same way as other fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49799





--- Comment #7 from Dirk Schulze <krit at webkit.org>  2010-11-19 06:58:58 PST ---
(From update of attachment 74375)
View in context: https://bugs.webkit.org/attachment.cgi?id=74375&action=review

Maybe I  misunderstood the intention of the after reading the text in the ChangeLog.

> LayoutTests/svg/filters/filter-x.svg:7
> +<filter id="filt" filterUnits="userSpaceOnUse" x="9.51" y="5" width="10" height="10">
> +    <feFlood flood-color="red" />
> +</filter>
> +</defs>
> +<rect x="0" y="0" width="10" height="10" filter="url(#filt)"/>

Why does it test the case, where width or height are < 0.5 like in the bug description? Just x has a fractional part. How is it related to the described problem?

Also, the reference image is red. We prefer green rects of the size 100x100. (The size is not a dogma)

> WebCore/rendering/RenderSVGResourceFilter.cpp:235
> +    if (!SVGImageBufferTools::createImageBuffer(absoluteDrawingRegion, absoluteDrawingRegion, sourceGraphic, ColorSpaceLinearRGB)) {
> +        ASSERT(!m_filter.contains(object));
> +        filterData->savedContext = context;
> +        m_filter.set(object, filterData.leakPtr());
>          return false;
> +    }

I agree, that the failure handling wasn't correct here. Just a bit confused why you were talking about width or height < 0.5 and how the test checks the correct handling. Since the test should return true here?!? :-P

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.