[Webkit-unassigned] [Bug 49744] Undo moves caret to invalid position

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49744


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74293|review?                     |review-
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2010-11-18 15:13:42 PST ---
(From update of attachment 74293)
View in context: https://bugs.webkit.org/attachment.cgi?id=74293&action=review

> WebCore/rendering/RenderBox.cpp:2926
> -    // FIXME: What about border and padding?
> -    IntRect rect(x(), y(), caretWidth, height());
> +    IntRect rect(x() + borderLeft() + paddingLeft(), y() + borderTop() + paddingTop(), caretWidth, height());
>      bool ltr = box ? box->isLeftToRightDirection() : style()->isLeftToRightDirection();

This won’t do the right thing in RTL cases. We need RTL coverage in a test case, and code that adds the appropriate right side border and padding.

> LayoutTests/editing/selection/caret-painting-after-paste-undo.html:22
>  \ No newline at end of file

Normally we put newlines at the ends of files like this one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.