[Webkit-unassigned] [Bug 49723] Expose default value of maxLength in Chromium API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49723


Ilya Sherman <isherman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74286|                            |commit-queue?
               Flag|                            |




--- Comment #8 from Ilya Sherman <isherman at chromium.org>  2010-11-18 13:29:17 PST ---
(From update of attachment 74286)
(In reply to comment #6)
> (From update of attachment 74284 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=74284&action=review
> 
> > WebKit/chromium/public/WebInputElement.h:83
> > +        WEBKIT_API static const int defaultMaximumLength;
> 
> since this is related to the maxLength attribute, it'd probably be nice to name
> it defaultMaxLength.  also, please add a comment indicating this relationship.
> the comment in your ChangeLog seems pretty good.  it would be nice to have it
> in the code as well.

Done =)

> > WebKit/chromium/src/WebInputElement.cpp:163
> > +const int WebInputElement::defaultMaximumLength =
> 
> nit: i would probably not insert a line break here as it is fine to exceed 80 chars in webkit code

Doh, keep forgetting that WebKit isn't 80-col -- thanks :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.