[Webkit-unassigned] [Bug 49723] Expose default value of maxLength in Chromium API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49723





--- Comment #6 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-11-18 13:22:52 PST ---
(From update of attachment 74284)
View in context: https://bugs.webkit.org/attachment.cgi?id=74284&action=review

> WebKit/chromium/public/WebInputElement.h:83
> +        WEBKIT_API static const int defaultMaximumLength;

since this is related to the maxLength attribute, it'd probably be nice to name
it defaultMaxLength.  also, please add a comment indicating this relationship.
the comment in your ChangeLog seems pretty good.  it would be nice to have it
in the code as well.

> WebKit/chromium/src/WebInputElement.cpp:163
> +const int WebInputElement::defaultMaximumLength =

nit: i would probably not insert a line break here as it is fine to exceed 80 chars in webkit code

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.