[Webkit-unassigned] [Bug 49465] Enabling test expectations analyzer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49465





--- Comment #4 from Victoria Kirst <vrk at google.com>  2010-11-18 11:48:27 PST ---
A few comments, but other than those things, LGTM! (I am not a WebKit committer though, so you should get someone else to take a look at this as well.)

> LayoutTests/platform/chromium/test_expectations.txt:56
> +// -KNOWNISSUE, UNIMPLEMENTED and TESTISSUE keyword in comments were added for analysis purpose

I think you might want to delete this line (or at least document it somewhere else) because these keywords aren't part of the "official" syntax for test_expectations.txt.

> LayoutTests/platform/chromium/test_expectations.txt:2924
> +BUGDPRANKE BUG60845 WIN LINUX : media/video-poster.html = PASS TEXT

I'm not sure what BUG<name> means. Does that mean dpranke is the owner of that bug? If so, maybe you should have just BUG60845 and make dpranke the owner of that bug?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.