[Webkit-unassigned] [Bug 49714] Yensign hack should work with Shift_JIS encoding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49714


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tony at chromium.org




--- Comment #4 from Tony Chang <tony at chromium.org>  2010-11-18 11:13:05 PST ---
(In reply to comment #3)
> > WebCore/platform/text/TextEncoding.cpp:211
> > +    return ((shiftJis && m_name == shiftJis) || (shiftJis2000 && m_name == shiftJis2000) || (eucJp && m_name == eucJp)) ? 0x00A5 : '\\';
> 
> I'm not really sure how performance critical this function is, but it's certainly invoked a lot, so I wouldn't be adding unnecessary null checks.

I think this is a correctness check.  If the m_name is NULL and shiftJis2000 is NULL, we'll return the wrong value.  I suppose you could reduce the number of comparisons by just NULL checking m_name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.