[Webkit-unassigned] [Bug 39908] Reentrant Geolocation tests crash with an assertion

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 18 06:34:04 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=39908





--- Comment #9 from Jeremy Orlow <jorlow at chromium.org>  2010-11-18 06:34:03 PST ---
(From update of attachment 74119)
View in context: https://bugs.webkit.org/attachment.cgi?id=74119&action=review

Steve is probably the best reviewer, but unfortunately he's on holiday.  Here are a few comments to get you started though.

> LayoutTests/ChangeLog:4
> +

include title and bug url at top...in other CLs too

> WebCore/page/Geolocation.cpp:530
> +        RefPtr<GeoNotifier> notifier = *it;

just store a pointer.  No need to ref it.

> WebCore/page/Geolocation.cpp:543
> +         RefPtr<GeoNotifier> notifier = *it;

same

> WebCore/page/Geolocation.cpp:544
> +             dest.add(notifier);

wrong indent

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list