[Webkit-unassigned] [Bug 48110] getBoundingClientRect: Do not truncate the coordinates to integers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48110


Cosmin Truta <ctruta at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74085|0                           |1
        is obsolete|                            |
  Attachment #74085|review?, commit-queue?      |
               Flag|                            |
  Attachment #74204|                            |review?, commit-queue?
               Flag|                            |




--- Comment #18 from Cosmin Truta <ctruta at chromium.org>  2010-11-17 22:26:38 PST ---
Created an attachment (id=74204)
 --> (https://bugs.webkit.org/attachment.cgi?id=74204&action=review)
Fix and layout tests

> So why don't you change the expectations in the test file, so it says PASS?

I spent some time trying to figure out how to reconcile Chromium vs. non-Chromium WebKit results, until (silly me) it eventually occurred to me that the place to put font-dependent (therefore platform-dependent) coordinates is the expectation file, not the source HTML.
So I added SKIP besides the usual PASS/FAIL and one of the tests, and I removed shouldBe() calls altogether in the other one.

In general, IMO, the shouldBe calls should be placed (no pun intended) only where there's a good reason to expect a certain number, or a certain formula. Everything else should be checked via expectation files.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.