[Webkit-unassigned] [Bug 49691] [NRWT] Remove a 'uri' member from TestInput class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49691





--- Comment #5 from Hayato Ito <hayato at chromium.org>  2010-11-17 17:42:18 PST ---
Thank you for the review.
I've updated patch. 'strip()' has been removed.

(In reply to comment #3)
> (From update of attachment 74162 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=74162&action=review
> 
> LGTM otherwise.
> 
> > WebKitTools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:-175
> > -    test_input.uri = port.filename_to_uri(test_input.filename).strip()
> 
> When you do make run_test() take a single input, just stuff this down into the port/* implementations so that the ports that do need to convert the test name to the uri can do so, and the ports that don't (e.g., the test port, the dryrun port), don't need to convert back.

Thank you. I'll do it for each ports. I don't think that is difficult work. 

> 
> > WebKitTools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:175
> > +    uri = port.filename_to_uri(test_input.filename).strip()
> 
> Nit: You don't actually need the strip() . filename_to_uri() doesn't append any whitespace. I'm not sure why this crept in at some point, and I've removed it in the patches-that-have-not-yet-been-uploaded-for-review :)

Done. I've removed 'strip()' in the patch-that-has-been-uploaded. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.