[Webkit-unassigned] [Bug 46258] [EFL] Add support for scaling the contents

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 17 13:33:54 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=46258


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68367|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #9 from Andreas Kling <kling at webkit.org>  2010-11-17 13:33:52 PST ---
(From update of attachment 68367)
View in context: https://bugs.webkit.org/attachment.cgi?id=68367&action=review

Whoa, this one is all over the place.
Please break this up into smaller patches, preferably separating the EFL-specific changes from the WebCore changes.

> WebCore/platform/ScrollView.cpp:870
> -    context->clip(visibleContentRect());
> +    IntRect visibleRect = visibleContentRect();
> +    context->clip(visibleRect);

What's going on here?

> WebCore/rendering/RenderBoxModelObject.cpp:114
> -    bool contextIsScaled = !currentTransform.isIdentityOrTranslationOrFlipped();
> +    bool contextIsScaled = false;

Please explain this change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list