[Webkit-unassigned] [Bug 49529] [gtk] SVGLineElement-dom-requiredFeatures.html and SVGLineElement-svgdom-requiredFeatures.html failing in the bots

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49529





--- Comment #4 from Rob Buis <rwlbuis at gmail.com>  2010-11-17 12:39:43 PST ---
Hi,

(In reply to comment #2)
> (In reply to comment #1)
> > Hi,
> > 
> > (In reply to comment #0)
> > > They work for me locally but apparently the startTest does not start the test in the bots. I'm skipping the tests until we find the issue. Dirk do you have any clue about why this could happen?
> > 
> > This sounds like the onclick is not triggered. You could try such a change to see if it helps:
> > 
> 
> Thanks for the help, I tried the change in the bots and apparently did not fix the issue, I also tried to change the point of the onclick but without success.

Dirks tip to try it manually is a good idea. Also I noticed setting fill is probably not correct for the line, could you try this patch instead:

diff --git a/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-dom-requiredFeatures.js b/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-dom-requiredFeatures.js
index b1f8e95..3a54c7a 100644
--- a/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-dom-requiredFeatures.js
+++ b/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-dom-requiredFeatures.js
@@ -8,7 +8,8 @@ lineElement.setAttribute("x1", "20");
 lineElement.setAttribute("y1", "20");
 lineElement.setAttribute("x2", "200");
 lineElement.setAttribute("y2", "200");
-lineElement.setAttribute("fill", "green");
+lineElement.setAttribute("stroke", "green");
+lineElement.setAttribute("stroke-width", "10px");

 rootSVGElement.appendChild(lineElement);

diff --git a/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-svgdom-requiredFeatures.js b/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-svgdom-requiredFeatures.js
index 2350445..2c0b9d0 100644
--- a/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-svgdom-requiredFeatures.js
+++ b/LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-svgdom-requiredFeatures.js
@@ -8,7 +8,8 @@ lineElement.setAttribute("x1", "20");
 lineElement.setAttribute("y1", "20");
 lineElement.setAttribute("x2", "200");
 lineElement.setAttribute("y2", "200");
-lineElement.setAttribute("fill", "green");
+lineElement.setAttribute("stroke", "green");
+lineElement.setAttribute("stroke-width", "10px");

 rootSVGElement.appendChild(lineElement);

Cheers,

Rob.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.