[Webkit-unassigned] [Bug 49671] New: webkit-patch create-bug throws AttributeError

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49671

           Summary: webkit-patch create-bug throws AttributeError
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: joepeck at webkit.org


Here I tried create-bug for the first time, and was shut down for missing an attribute.
I can't tell if it was just a bug in the python code or if I did something wrong.

    shell> webkit-patch create-bug
    Bug title: Allow no-store resources to be used for back navigation
    Bug comment (hit ^D on blank line to end):
    The HTTP spec allows 'Cache-Control: no-store' resources to be used when used for "History", such as back/forward navigation.
    ^D

    Traceback (most recent call last):
      File "/Users/pecoraro/Code/webkit-open-source/WebKitTools/Scripts/webkit-patch", line 70, in <module>
        main()
      File "/Users/pecoraro/Code/webkit-open-source/WebKitTools/Scripts/webkit-patch", line 65, in main
        WebKitPatch(__file__).main()
      File "/Users/pecoraro/Code/webkit-open-source/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main
        result = command.check_arguments_and_execute(options, args, self)
      File "/Users/pecoraro/Code/webkit-open-source/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute
        return self.execute(options, args, tool) or 0
      File "/Users/pecoraro/Code/webkit-open-source/WebKitTools/Scripts/webkitpy/tool/commands/upload.py", line 483, in execute
        self.create_bug_from_patch(options, args, tool)
      File "/Users/pecoraro/Code/webkit-open-source/WebKitTools/Scripts/webkitpy/tool/commands/upload.py", line 459, in create_bug_from_patch
        diff = tool.scm().create_patch(options.git_commit)
    AttributeError: Values instance has no attribute 'git_commit'


create-bug does not appear to require any params, they are all optional, so my guess is
its just a python issue.

    shell> webkit-patch help create-bug
    create-bug [options] [COMMITISH]   Create a bug from local changes or local commits

    Options:
      --cc=CC               Comma-separated list of email addresses to carbon-
                            copy.
      --component=COMPONENT
                            Component for the new bug.
      --no-prompt           Do not prompt for bug title and comment; use commit
                            log instead.
      --no-review           Do not mark the patch for review.
      --request-commit      Mark the patch as needing auto-commit after review.

I am on `git svn find-rev HEAD` => r72103.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.