[Webkit-unassigned] [Bug 49613] [V8] ASSERT(WTF::isMainThread()) fails in V8Binding::int32ToWebCoreString in workers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49613





--- Comment #4 from Nate Chapin <japhet at chromium.org>  2010-11-17 09:57:25 PST ---
(In reply to comment #3)
> (From update of attachment 74028 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=74028&action=review
> 
> > WebCore/bindings/v8/V8Binding.cpp:398
> > +    if (WTF::isMainThread())
> 
> Please, check by running http://dromaeo.com/?dom performance implications.
> 
> I haven't looked into this code for some time, but WTF::isMainThread apparently used to be pretty expensive.

IIRC, globalObjectPrototypeIsDOMWindow() in V8DOMWrapper.cpp is a fairly cheap check for whether we're in a worker context or not.  Should we try to generalize that and put it somewhere public?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.