[Webkit-unassigned] [Bug 49479] Building QtWebKit fails on uClibc (0.9.31)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49479


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73782|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #9 from Andreas Kling <kling at webkit.org>  2010-11-17 03:43:49 PST ---
(From update of attachment 73782)
View in context: https://bugs.webkit.org/attachment.cgi?id=73782&action=review

> JavaScriptCore/ChangeLog:5
> +        Merged changes from QtScript which fixes missing pthread_getattr_np not available on uClibc causing build error.

This is a bit muddy. Suggestion:

==
Fix currentThreadStackBase() compilation against uClibc

uClibc doesn't have pthread_getattr_np or pthread_attr_getstack.
Patch originally from QtScript.
==

> JavaScriptCore/runtime/Collector.cpp:77
> +// versions of uClibc 0.9.31 and below do not have
> +// pthread_getattr_np or pthread_attr_getstack.

This seems a bit strange to me, since 0.9.31 is the latest version (AFAICT from uclibc.org)
Shouldn't we be doing this for *any* uClibc version, not just <= 0.9.31?

> JavaScriptCore/runtime/Collector.cpp:544
> +    size_t lineLen = 0;

We generally don't abbreviate in WebKit, "lineLength" sounds better here.

> JavaScriptCore/runtime/Collector.cpp:551
> +        if (sscanf (line, "%lx-%lx", &from, &to) != 2)

Style, remove space after sscanf.

> JavaScriptCore/runtime/Collector.cpp:557
> +            return (void *)from;

Style, remove space after void.

> JavaScriptCore/runtime/Collector.cpp:559
> +            return (void *)to;

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.