[Webkit-unassigned] [Bug 49366] [Chromium][DRT] EventSender.contextClick() should aware spellchecking

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49366





--- Comment #8 from MORITA Hajime <morrita at google.com>  2010-11-17 01:33:52 PST ---
Hi Kent-san, thank you for reviewing!
I updated the patch.

(In reply to comment #3)
> (From update of attachment 74087 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=74087&action=review
> 
> > LayoutTests/ChangeLog:9
> > +        - Added a test for improve the coverage.
> > +        - Unskipped one passed test.
> Do not do two things in one patch.  Adding a test (not Chromium-specific) should be separated from the DRT change (Chromium-specific).

Sure. I removed the test from this patch. It will be filed as another bug
and fix it after this change is ported to test_shell.

> > LayoutTests/platform/chromium/test_expectations.txt:696
> > -// Need to dump context menu items on eventSender.contextClick(true).
> > -BUGWK39105 : editing/spelling/context-menu-suggestions.html = TEXT
> > +// Need to enable mock spellchecker. see Bug 45633
> > +BUGWK45633 WIN LINUX : editing/spelling/context-menu-suggestions.html = TEXT
> 
> The DRT change is DRT-only.  So test_shell still fail with it, right?
Yes. I discarded this change. I'll do this after test_shell porting.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.