[Webkit-unassigned] [Bug 49366] [Chromium][DRT] EventSender.contextClick() should aware spellchecking

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49366


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74089|review?                     |review-
               Flag|                            |




--- Comment #6 from Kent Tamura <tkent at chromium.org>  2010-11-17 01:31:36 PST ---
(From update of attachment 74089)
View in context: https://bugs.webkit.org/attachment.cgi?id=74089&action=review

> WebKitTools/DumpRenderTree/chromium/EventSender.cpp:756
> +        for (int i = 0; i < suggestions.size(); ++i) 

"i" should be unsigned.

> WebKitTools/DumpRenderTree/chromium/MockSpellCheck.cpp:95
> +void MockSpellCheck::fillSuggestionList(const WebString& word,
> +                                        Vector<WebString>* suggestions)

nit: no need to break the line

> WebKitTools/DumpRenderTree/chromium/MockSpellCheck.h:66
> +    void fillSuggestionList(const WebKit::WebString& word,
> +                            Vector<WebKit::WebString>* suggestions);

nit: no need to break the line

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.