[Webkit-unassigned] [Bug 48821] "elements" for form and fieldsset don't conform to the HTML5 spec

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48821





--- Comment #10 from Kent Tamura <tkent at chromium.org>  2010-11-17 01:27:04 PST ---
(In reply to comment #9)
> Created an attachment (id=74088)
 --> (https://bugs.webkit.org/attachment.cgi?id=74088&action=review) [details]
> A minimum diff
> 
> Thank you for your help. With attached a minimum patch, I got following errors:
> 
> In file included from /Users/bashi/webkit/work/WebCore/html/HTMLFormControlElement.cpp:49:
> /Users/bashi/webkit/work/WebCore/html/ValidityState.h: In member function ‘void WebCore::ValidityState::ref()’:
> /Users/bashi/webkit/work/WebCore/html/ValidityState.h:39: error: request for member ‘ref’ is ambiguous

This ambiguity can be avoided by adding

    using TreeShared<ContainerNode>::ref;
    using TreeShared<ContainerNode>::deref;

to HTMLFormControlElement declaration.  See Node.h.

Having non-virtual ref()/deref() and virtual def()/deref() is confusing.  So FormAssociatedElementInterface (I don't like to add "Interface" to the name) definition should be similar to EventTarget.

class FormAssociatedElement {
    void ref() { refFormAssociatedElement(); }
    void deref() { derefFormAssociatedElement(); }
    virtual void refFormAssociatedElement() = 0;
    virtual void derefFormAssociatedElement() = 0;
};

HTMLFormControlElement should have:
void HTMLFormControlElement::refFormAssociatedElement() { ref(); }
void HTMLFormControlElement::derefFormAssociatedElement() { deref(); }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.