[Webkit-unassigned] [Bug 48809] Update correct content state during back/forward navigations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48809





--- Comment #34 from Charles Reis <creis at chromium.org>  2010-11-16 19:48:23 PST ---
(In reply to comment #33)
> My thinking here is that if we keep pulling on this thread that we'll find that things can be simpler, which would be good.

The main difficulty is the way that saveDocumentState saves the state of different items (previous or current) at different points in time.  That function assumes that "m_previousItem == 0" implies that the load has completed, in which case it should use current rather than previous.

I've teased apart the state of whether the load has completed from the value of previousItem, by adding a m_frameLoadCompleted field.  This has the advantage of matching the previous WebCore behavior, while keeping a valid item in m_previousItem so that Chromium's UpdateSessionHistory call works.

It might be possible to simplify things further, but I'd need help understanding more of the assumptions around frame loading.  Since Chromium is currently broken on fragment back/forward navigations, it might be nice to get a simple fix like this in place before taking time to refactor further.

Thoughts?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.