[Webkit-unassigned] [Bug 49633] Add .responseType and .response to XMLHttpRequest

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49633


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mjs at apple.com




--- Comment #4 from Alexey Proskuryakov <ap at webkit.org>  2010-11-16 17:33:32 PST ---
Looks reasonable to me, although passing a string wouldn't be my preference.

JSXMLHttpRequest::markChildren() needs to mark the response. And looking at it, I'm surprised that it doesn't mark responseXML - that's likely a bug.

+    } else {
+        ec = SYNTAX_ERR;
+    }

There should be no braces around single line blocks.

+    enum ResponseTypeCode {
+        RESPONSETYPE_DEFAULT,
+        RESPONSETYPE_TEXT, 
+        RESPONSETYPE_DOCUMENT,
+        RESPONSETYPE_BLOB,
+        RESPONSETYPE_ARRAYBUFFER

Enums shouldn't use ALL_CAPS.

> * the return type on the .response attribute should by "Any" in the .idl, but I don't know how to do that

Would Object work?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.