[Webkit-unassigned] [Bug 49563] [chromium] Fix negative letter spacing in complex text on linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49563


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74048|review?                     |review+
               Flag|                            |




--- Comment #4 from Tony Chang <tony at chromium.org>  2010-11-16 15:44:10 PST ---
(From update of attachment 74048)
View in context: https://bugs.webkit.org/attachment.cgi?id=74048&action=review

One option for chromium win/mac is to mark the test as expected to fail, which gives you a chance to rebaseline it without turning the tree red.  gtk, qt, and win, you'll just have to break the tree and grab the results from the waterfall.

> WebCore/platform/graphics/chromium/FontLinux.cpp:54
> +using namespace std;

Can we do without this?

> WebCore/platform/graphics/chromium/FontLinux.cpp:561
> +    m_pixelWidth = max(position, 0.0);

std::max seems safer to avoid ambiguity.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.