[Webkit-unassigned] [Bug 45174] Freeze in VisiblePosition::leftVisuallyDistinctCandidate with ::first-letter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45174





--- Comment #7 from Levi Weintraub <leviw at google.com>  2010-11-16 14:34:09 PST ---
Created an attachment (id=74042)
 --> (https://bugs.webkit.org/attachment.cgi?id=74042&action=review)
Patch

This patch solves a number of issues surrounding first-letter:
- leftVisuallyDistinctCandidate no longer hangs
- the caret can correctly be positioned in first-letter content
- typing at the end of an editable field with first-letter content no longer replaces the final character (Bug 26442)

There are still serious issues with selection and contenteditable, all stemming from the fundamental break from the rendering norm that first-letter presents by having part of a text node's rendered content in a fully separate renderer than the one it directly owns. Solving the remaining bugs involves making more parts of the code aware of this specific render-tree structure, which makes me uncomfortable.

I believe that having the text node's renderer be the parent (or grand-parent) of *all* associated RenderTextFragments would solve many of these problems, but I'll defer to those who better understand WebKit rendering. Feedback is very appreciated. I think this solution is not ideal.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.