[Webkit-unassigned] [Bug 49613] [V8] ASSERT(WTF::isMainThread()) fails in V8Binding::int32ToWebCoreString in workers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49613


Nate Chapin <japhet at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74028|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Nate Chapin <japhet at chromium.org>  2010-11-16 13:10:32 PST ---
(From update of attachment 74028)
View in context: https://bugs.webkit.org/attachment.cgi?id=74028&action=review

Other than the style nits, this looks ok.  However, I'd appreciate it if you waited for antonm to agree before committing :)

> WebCore/bindings/v8/V8Binding.cpp:390
>      } else
> -        webCoreString = String::number(value);
> +      webCoreString = String::number(value);

Indent 4.

> WebCore/bindings/v8/V8Binding.cpp:399
> +    if (WTF::isMainThread())
> +      return int32ToWebCoreStringFast(value);

Indent 4.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.