[Webkit-unassigned] [Bug 36721] Return correct load result to NPAPI plugins calling getUrlNotify on target frames

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 16 12:31:49 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=36721





--- Comment #11 from Robert Hogan <robert at webkit.org>  2010-11-16 12:31:48 PST ---
(In reply to comment #10)
> Created an attachment (id=74021)
 --> (https://bugs.webkit.org/attachment.cgi?id=74021&action=review) [details]
> Patch

A couple of points on this:

- I think the code added to FrameLoader needs to be guarded out for Mac Safari builds - since it implements something similar to this in WebBaseNetscapePluginView.mm. I'd be grateful is someone could confirm this.
- The alternative to the impementation in the patch is to pass PluginView and some other details to frameloader and call back when the load completes. Given that the load to a target frame can destroy the PluginView this seemed a risky option so I avoided it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list