[Webkit-unassigned] [Bug 49550] Fix android specific history bug
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 16 03:51:33 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=49550
--- Comment #3 from Andrei Popescu <andreip at google.com> 2010-11-16 03:51:33 PST ---
> No new tests. (OOPS!)
Please remove this and explain why you don't add a test.
> // Sometimes the parent scrollView is not set for some iFrame when it's first loaded
>// in case of history going back.
Just curious: can you please provide more info about the circumstances when the parent is not set?
> android::WebViewCore *webViewCore = android::WebViewCore::getWebViewCore(this);
There should not be Android namespace code in WebCore, this is a layering violation. You should use the PlatformBridge instead. I know you haven't introduced this yourself in this patch but it'd be good to think how to address the layering violations in this file.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list