[Webkit-unassigned] [Bug 49575] New: webkit-patch blows up when the first line of ChangeLog is a blank line

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 15 17:51:36 PST 2010


           Summary: webkit-patch blows up when the first line of ChangeLog
                    is a blank line
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: eric at webkit.org, abarth at webkit.org,
                    levin at chromium.org, dpranke at chromium.org

When there is a blank line at the beginning of ChangeLog, webkit-patch crashes with the following stack trace:

Total errors found: 0 in 8 files
Traceback (most recent call last):
  File "WebKitTools/Scripts/webkit-patch", line 70, in <module>
  File "WebKitTools/Scripts/webkit-patch", line 65, in main
  File "/co/webkit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main
  File "/co/webkit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute
  File "/co/webkit/WebKitTools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 43, in execute
  File "/co/webkit/WebKitTools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors
  File "/co/webkit/WebKitTools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
  File "/co/webkit/WebKitTools/Scripts/webkitpy/tool/steps/preparechangelog.py", line 61, in run
  File "/co/webkit/WebKitTools/Scripts/webkitpy/tool/steps/preparechangelog.py", line 54, in _ensure_bug_url
AttributeError: 'NoneType' object has no attribute 'bug_id'

It should print out more user-friendly message or remove leading blank lines.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list