[Webkit-unassigned] [Bug 49396] Make WebWidget actively notify client when compositing enables

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49396





--- Comment #4 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-11-15 13:57:17 PST ---
(From update of attachment 73919)
View in context: https://bugs.webkit.org/attachment.cgi?id=73919&action=review

> WebKit/chromium/src/WebViewImpl.cpp:-1022
> -        m_layerRenderer->present();

nice to see this cleanup!

> WebKit/chromium/public/WebWidgetClient.h:54
> +    virtual void didAcceleratedCompositingEnable(bool active) { }

why this over didActivateAcceleratedCompositing?  when vangelis added the isAcceleratedCompositingActive,
i suggested using "enabled" instead of "active" as the suffix, but he argued against "enable" since that
sounds like the compile-time option (is the code enabled at all).  so, we went with "active", and he used
that throughout the codebase (both webkit and chrome).  can we stick with "active"/"activate"?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.