[Webkit-unassigned] [Bug 49549] New: [GTK] gdk_pixbuf_get_from_surface from GtkVersioning.h is broken on GTK+ 2 builds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49549

           Summary: [GTK] gdk_pixbuf_get_from_surface from GtkVersioning.h
                    is broken on GTK+ 2 builds
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Keywords: Gtk
          Severity: Normal
          Priority: P3
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: mrobinson at webkit.org


The line:

    g_return_val_if_fail(!surface, NULL);

is incorrectly causing the method to fail if the surface is not null. The condition should be reversed. This causes problems loading custom cursors. For example, loading LayoutTests/fast/blockflow/broken-ideographic-font.html causes many CRITICAL GLib assertions when trying to select the vertically oriented text.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.