[Webkit-unassigned] [Bug 48506] Move DeviceOrientationClientMock from LayoutTestController to WebViewHost

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48506


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73904|review?                     |review+
               Flag|                            |




--- Comment #11 from Jeremy Orlow <jorlow at chromium.org>  2010-11-15 09:15:40 PST ---
(From update of attachment 73904)
View in context: https://bugs.webkit.org/attachment.cgi?id=73904&action=review

r=me

> WebCore/platform/mock/DeviceOrientationClientMock.cpp:43
> +    ASSERT(controller);

It's probably better to keep the m_controler check after

> WebCore/platform/mock/DeviceOrientationClientMock.cpp:-43
> -    ASSERT(m_controller);

I think it's better to leave this one.

> WebKitTools/ChangeLog:9
> +        https://bugs.webkit.org/show_bug.cgi?id=48506

"""
Reviewed by

Title
this url

description
"""

Also describe why it's a design constraint.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.