[Webkit-unassigned] [Bug 25831] [GTK] events missing when a document is (re)loaded

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25831





--- Comment #8 from Mario Sanchez Prada <msanchez at igalia.com>  2010-11-15 02:28:51 PST ---
(In reply to comment #7)
> (From update of attachment 73716 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=73716&action=review
> 
> > WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:165
> > +        return returnString(coreObject->document()->title());
> 
> only returning the title here limits some future flexibility, so as using aria-label, name or something 
> else that might also be available

My (probably poor) reasoning here was that no string was being returned for the object with the webArea role so that returning something like this would be at least an improvement (and very useful for emitting the signals along with this patch in the right way).

But most likely you're right and I should instead re-write this in a way that all those other possible situations were taken into account as well (perhaps moving this lines to the end of the function, as some kind of fallback in case no other string was found, or by defining a dedicated static function).

I'll come up with a new patch soon, just willing to share these thoughts now

> > WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:215
> > +
> 
> don't know how you would get into this method to turn on AX, since the only caller first checks if 
> AX is on before calling this method... see notifyStatus() change

My bad, sure. Thanks for pointing it out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.