[Webkit-unassigned] [Bug 45443] [GTK] Support for viewport meta tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45443





--- Comment #59 from Joone Hur <joone at kldp.org>  2010-11-14 20:21:48 PST ---
> * viewport-attributes-recompute-requested is emitted, giving the application the possibility of providing available size, and even override screen size if required

It seems quite good that adding the viewport-attributes-recompute-requested signal allows the user to override the screenWidth/height and availableWidth/height.
However, according to the viewport meta-tag spec, the device-width/height keyword is used instead of the screen-width/height. So, I think that using the device-width/height would avoid confusion for the developers.

> * Qt uses a hardcoded DPI of 160, why is that?
I'm not sure, but Nokia device may use the value.

Is it wrong to call webViewGetDPI() to set the deviceDPI value basically? 

> * www.engadget.com seems to work fine, except it has scrolling 100% of the time, probably because our calculation will have to take the space occupied by the scrollbars into account =(
> * most sites apparently do some crazy stuff, providing very big width and height values, and a very small scale factor - it looks like using full content zoom alone is not enough!

Your patch related to GtkLauncher doesn't scale web pages if the web pages don't have viewport meta tags. So, do you mean that you tested the web sites, which have viewport meta tags?
In case of apple.com, it has viewport meta tags, and works well.

> * full content zoom fails miserably at resizing text in http://touch.facebook.com/, which is not fun

Most mobile sites for the iPhone are not zoomed-in/out because user-scalable = 0 as follows,

<meta name="viewport" content="width=device-width; initial-scale=1.0; maximum-scale=1.0; user-scalable=0;" /> 

> So, do you guys see any trouble with this API? What use cases are not covered? What was better in the previous approach?

We need to let the desktopWidth, deviceDPI also be overridden, because there would be some cases for the user to set these values manually.

Thanks kov, your patch improved my patch so much.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.