[Webkit-unassigned] [Bug 47813] [HTML5] "form" attribute support for form control elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47813





--- Comment #21 from Kenichi Ishibashi <bashi at google.com>  2010-11-14 19:06:37 PST ---
(From update of attachment 73828)
View in context: https://bugs.webkit.org/attachment.cgi?id=73828&action=review

Kent-san,

Thank you for review. I'll post revised patch soon.

>> LayoutTests/fast/forms/form-attribute-expected.txt:7
>> +FIXME: <label> and <object> don't support the form attribute for now.
> 
> nit: It's ok to add test cases for <label> and <object> now. -expected.txt contains FAIL lines in that case.

I see. I've added test cases for <label> and <object>.

>> WebCore/dom/Document.cpp:4368
>> +void Document::registerFormElementWithFormAttribute(Element* e)
> 
> The parameter name "e" is not good.  It should be "control", "formControl", "element" or something.

Changed to control. Thanks!

>> WebCore/dom/Document.cpp:4374
>> +void Document::unregisterFormElementWithFormAttribute(Element* e)
> 
> ditto.

ditto.

>> WebCore/dom/Document.h:487
>> +    void unregisterFormElementWithFormAttribute(Element* e);
> 
> The argument name "e" doesn't add any useful information.  So we should remove it.

Removed.

>> WebCore/html/HTMLFormElement.cpp:418
>> +        unsigned middle = (left + right) / 2;
> 
> Possible integer overflow.  Fix it.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.