[Webkit-unassigned] [Bug 49341] REGRESSION: Select combo-box not displayed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49341





--- Comment #23 from Robert Hogan <robert at webkit.org>  2010-11-14 04:14:28 PST ---
diff --git a/WebCore/html/HTMLOptionElement.h b/WebCore/html/HTMLOptionElement.h
index c1791d7..1572acd 100644
--- a/WebCore/html/HTMLOptionElement.h
+++ b/WebCore/html/HTMLOptionElement.h
@@ -68,7 +68,7 @@ private:

     virtual bool supportsFocus() const;
     virtual bool isFocusable() const;
-    virtual bool rendererIsNeeded(RenderStyle*) { return false; }
+    virtual bool rendererIsNeeded(RenderStyle*) { return true; }
     virtual void attach();
     virtual void detach();
     virtual void setRenderStyle(PassRefPtr<RenderStyle>);


fixes the bug. It only breaks 1 layout test on Qt - adding an extra line of whitespace to fast/table/incomplete-table-in-fragment-hang.html - which seems benign.

Is it the correct solution though? Rendering elements inside an option element isn't something the rendere has had to do before so it seems like the kind of change that could break sites on WebKit.

What do you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.