[Webkit-unassigned] [Bug 49306] Fix autofill popup height computation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 12 22:30:42 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=49306


Ilya Sherman <isherman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73809|                            |commit-queue?
               Flag|                            |




--- Comment #14 from Ilya Sherman <isherman at chromium.org>  2010-11-12 22:30:41 PST ---
(From update of attachment 73809)
(In reply to comment #7)
> (In reply to comment #4)
> > (From update of attachment 73467 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=73467&action=review
> > 
> > It's nice if we can add a test (maybe manual test, unfortunately) for this change.
> 
> AFAIK this code is used only be Chromium autofill, and there is no good way to add a test for this from within WebKit -- even a manual one.  Eventually I'd like to add a way to test this popup more generally, but that's outside the scope of this patch.

Looks like I was dead wrong here -- this code is indeed used by both <select> elements and autofill popups.  The previous patch broken <select> elements that needed scroll bars; this patch should fix that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list