[Webkit-unassigned] [Bug 49484] Some FrameLoader.h Cleanup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49484


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73791|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org>  2010-11-12 16:59:58 PST ---
(From update of attachment 73791)
View in context: https://bugs.webkit.org/attachment.cgi?id=73791&action=review

> WebCore/ChangeLog:23
> +        Removed function signatures without any implementation. The functions
> +        used to exist, and were nicely refactored into PageCache in r60688 and
> +        the signatures were left behind.
> +
> +        Removed function signature setLoadType. Added in r17238 back when the
> +        file was named WebFrameLoader, and the implementation was lost during
> +        the transition from its mm implementation.
> +
> +        Removed function signature updateHistoryAfterClientRedirect. Implementation
> +        and call points were removed in r18541 but the signature was left behind,
> +        and jumped files!
> +
> +        Removed unused debug variable m_didDispatchDidCommitLoad. It was added
> +        and used in Assertions in r28399. It was removed soon after, in r28464
> +        because they were, "firing like crazy. Not sure why yet." It was
> +        never used again.

I'd probably put this in the bug, not ChangeLog. But it's nothing compared to the fact that you actually investigated the history in such detail, that's really nice.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.