[Webkit-unassigned] [Bug 49396] Make WebWidget actively notify client when compositing enables

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 12 16:26:33 PST 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
  Attachment #73633|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #2 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-11-12 16:26:33 PST ---
(From update of attachment 73633)
View in context: https://bugs.webkit.org/attachment.cgi?id=73633&action=review

> WebKit/chromium/src/WebViewImpl.cpp:2383
> +        m_layerRenderer->finish(); // finish all GL rendering before we hide the window? TODO(nduca) fixthisshit

TODO(nduca) -> FIXME and leave a more descriptive comment for someone else who may be reading this code.

> WebKit/chromium/src/WebViewImpl.cpp:2390
> +        m_layerRenderer->resizeOnscreenContent(WebCore::IntSize(std::max(1, m_size.width),

no need for the WebCore prefix.

> WebKit/chromium/public/WebWidgetClient.h:54
> +    virtual void didChangeAcceleratedCompositingActive(bool active) { }

nit: how about didActivateAcceleratedCompositing(bool)?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list