[Webkit-unassigned] [Bug 38044] QWebFrame::render() clips content right of 640 pixels wide when rendering to a QImage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38044


Viatcheslav Ostapenko <ostapenko.viatcheslav at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ostapenko.viatcheslav at nokia
                   |                            |.com




--- Comment #10 from Viatcheslav Ostapenko <ostapenko.viatcheslav at nokia.com>  2010-11-12 15:25:38 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > 
> > > you might be getting the QWebElement from an existing view, so in that case you do not want to change the viewport, unless you would somewhat clone the element.
> > 
> > So do you think the bug is invalid, or just hard to fix? ;-)
> 
> invalid to me.

No, I don't think it's invalid.
Generally, there is now no _right_ way to render contents without clipping to viewport. Suggested QWebElement::render is not very usable in this case, because it doesn't have any clipping paramter and will traverse the whole webkit render tree if only part of the page (different from viewport) been rendered.

I think QWebFramePrivate::renderRelativeCoords unnecessarily clips rendered content to viewport (framerect). It used in 3 places (variants of QWebFrame::render method) and those places all default to framerect, if clipping was not specified or empty. IMHO, if clipping _was_ specified, than it should be used as it is (well, may be clipped to contents rect). 

So far clipping in QWebFramePrivate::renderRelativeCoords contradicts to the code written in QWebFrame::render(QPainter* painter, RenderLayer layer, const QRegion& clip) .

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.