[Webkit-unassigned] [Bug 23351] Add preference to not select when right-clicked

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 12 08:05:30 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=23351





--- Comment #38 from Antonio Gomes <tonikitoo at webkit.org>  2010-11-12 08:05:29 PST ---
(In reply to comment #37)
> (In reply to comment #36)
> > Sorry Avi, maybe I misexplained: it is a Mac-specific behavior.
> 
> I'm very confused now. You said that my original patch would regress GTK behavior, and you gave me a code snippet that seemed to set Mac behavior. So if my new patch that gives this behavior to Mac/Unix is wrong, what would you recommend?
> 
You would regress GTK at that time. Now Gtk uses Linux behavior,not Mac. So only Mac wants this.

> > This is not the right way to test this. See LayoutTestController::setEditingBehavior. grep for it. It basically makes it possible to test all editing behavior and having test expectations shared cross all platforms..
> 
> I'll rewrite it. BTW, setEditingBehavior seems to take 'mac' and 'win' for parameters. What's the parameter for Unix? Whatever it is, I see that in our repo (webkit/tools/test_shell/layout_test_controller.cc) we don't have it.

It should be 'unix', but other tests have not being using it. Yours would be the first :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list