[Webkit-unassigned] [Bug 49437] SVGAnimations with IRI references via 'xlink:href' are slow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49437





--- Comment #7 from Nikolas Zimmermann <zimmermann at kde.org>  2010-11-12 06:36:39 PST ---
(In reply to comment #5)
> (In reply to comment #2)
> > (From update of attachment 73731 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=73731&action=review
> > 
> > Hm, I'm slightly worried that we have no new tests about this.
> > What happens when you change 'target' dynamically via JS, while the animation is running? I guess m_targetElement won't be recached from reading the code...
> 
> Oh sorry, misunderstood the comment. You were not talking about removing the target, but _changing_ the target. Indeed this needs to be tested. Not necessarily part of this patch. And I could imagine situations that really cause wrong results.
> I'll write some test cases and open a new bug for these scenarios.
I think it's part of this patch, as before your patch changing the target, would be immediately cause a new targetElement() to be returned,, which is not the case anymore.
(I'm sure that would reveal other bugs, but still..)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.