[Webkit-unassigned] [Bug 49437] SVGAnimations with IRI references via 'xlink:href' are slow
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 12 06:07:27 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=49437
Nikolas Zimmermann <zimmermann at kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #73731|review? |review-
Flag| |
--- Comment #2 from Nikolas Zimmermann <zimmermann at kde.org> 2010-11-12 06:07:27 PST ---
(From update of attachment 73731)
View in context: https://bugs.webkit.org/attachment.cgi?id=73731&action=review
Hm, I'm slightly worried that we have no new tests about this.
What happens when you change 'target' dynamically via JS, while the animation is running? I guess m_targetElement won't be recached from reading the code...
I think you should try that and compare to Opera.
> WebCore/svg/SVGAnimateMotionElement.cpp:55
> -bool SVGAnimateMotionElement::hasValidTarget() const
> +bool SVGAnimateMotionElement::hasValidTarget()
Why is it a non-const version?
> WebCore/svg/SVGAnimateTransformElement.cpp:106
> + SVGElement* targetElement = this->targetElement();
I'd rather use const_cast<SVGAnimateTransformElement*>(this)->targetElement() here!
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list