[Webkit-unassigned] [Bug 47813] [HTML5] "form" attribute support for form control elements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 12 04:10:51 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=47813





--- Comment #17 from Kent Tamura <tkent at chromium.org>  2010-11-12 04:10:51 PST ---
(In reply to comment #16)
> > > WebCore/html/HTMLFormElement.cpp:403
> > > +static int compareTreeOrder(Node* n1, int depth1, Node* n2, int depth2)
> > 
> > - 'n1' 'n2" are not good names.  They should be node1 and node2.
> > - This function should belong to Document class.
> > - The "int" return value is not good.  We should introduce new enum.
> 
> I see. I'll move the function to Document class. So, should we also make nodeDepth() belong to other class, say, Node class?

Oops, I have found Node::compareDocumentPosition() now.  So we can use it and compareTreeOrder() is not needed.  I'm sorry for wasting your time.
compareDocumentPosition() looks slower than your compareTreeOrder().  But it would be acceptable.  We don't need nodeDepth() too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list