[Webkit-unassigned] [Bug 49345] [Chromium] Add a basic GestureManager to Chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49345





--- Comment #3 from Robert Kroeger <rjkroege at chromium.org>  2010-11-12 03:29:10 PST ---
(In reply to comment #2)
> (From update of attachment 73542 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=73542&action=review
> 
> > WebKit/chromium/src/GestureManager.h:109
> > +#if defined(UNIT_TEST)
> > +public: 
> > +#else
> > +protected:
> > +#endif 
> 
> This is unfortunate.

It certainly looks a bit ugly. I could probably get rid of it by sub-classing the GestureManager in the test.

> 
> > WebKit/chromium/src/GestureManager.h:139
> > +    // The WebViewImpl that invoked the GestureManager.
> > +    WebViewImpl* m_WebView;  
> 
> m_webView
>   ^-- lower case (several instances in this file)

some of this code use to be in a patch-for-Chromium so it may have other Chromium-style -> WebKit style issues. I'll scrub carefully before the next patch iteration.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.