[Webkit-unassigned] [Bug 49291] Add capability for displaying warnings to autofill popup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49291





--- Comment #8 from Ilya Sherman <isherman at chromium.org>  2010-11-12 03:24:32 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > > WebCore/platform/chromium/PopupMenuClientChromium.h:31
> > > +    virtual bool itemIsWarning(unsigned listIndex) const = 0;
> > 
> > I think it would have been better to add this to PopupMenuClient (like we did previously for item labels).
> 
> For the sake of consistency, we should probably either add this to PopupMenuClient or move the labels out of there.  I don't know the codebase nearly well enough, so I'll defer to others' wisdom here.

The latest patch sidesteps this issue by moving all the code in question down into AutoFillPopupMenuClient.cpp.  The original question is likely to become relevant again in the near future, though, as we might want to distinguish warnings by slightly more than just tweaking the font.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.