[Webkit-unassigned] [Bug 49240] Implement formaction, formenctype, formmethod and formtarget attributes for input and button tags

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49240


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73712|review?                     |review-
               Flag|                            |




--- Comment #23 from Kent Tamura <tkent at chromium.org>  2010-11-12 00:39:22 PST ---
(From update of attachment 73712)
View in context: https://bugs.webkit.org/attachment.cgi?id=73712&action=review

> LayoutTests/ChangeLog:21
> +        * fast/forms/formaction-attribute-expected.txt: Added.
> +        * fast/forms/formaction-attribute.html: Added.
> +        * fast/forms/formmethod-attribute-button-html-expected.txt: Added.
> +        * fast/forms/formmethod-attribute-button-html.html: Added.
> +        * fast/forms/formmethod-attribute-input-html-expected.txt: Added.
> +        * fast/forms/formmethod-attribute-input-html.html: Added.
> +        * fast/forms/formtarget-attribute-button-html-expected.txt: Added.
> +        * fast/forms/formtarget-attribute-button-html.html: Added.
> +        * fast/forms/formtarget-attribute-input-html-expected.txt: Added.
> +        * fast/forms/formtarget-attribute-input-html.html: Added.
> +        * fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Added.
> +        * fast/forms/mailto/formenctype-attribute-button-html.html: Added.
> +        * fast/forms/mailto/formenctype-attribute-input-html-expected.txt: Added.
> +        * fast/forms/mailto/formenctype-attribute-input-html.html: Added.

There is no submit-form-attribute.html.

> LayoutTests/fast/forms/script-tests/submit-form-attributes.js:6
> +input.type="submit";

nit: Need spaces around "=".

> LayoutTests/fast/forms/script-tests/submit-form-attributes.js:100
> +button.type="submit";

ditto.

> WebCore/ChangeLog:20
> +        Tests: fast/forms/formaction-attribute.html
> +               fast/forms/formmethod-attribute-button-html.html
> +               fast/forms/formmethod-attribute-button-js.html
> +               fast/forms/formmethod-attribute-input-html.html
> +               fast/forms/formmethod-attribute-input-js.html
> +               fast/forms/formtarget-attribute-button-html.html
> +               fast/forms/formtarget-attribute-button-js.html
> +               fast/forms/formtarget-attribute-input-html.html
> +               fast/forms/formtarget-attribute-input-js.html
> +               fast/forms/mailto/formenctype-attribute-button-html.html
> +               fast/forms/mailto/formenctype-attribute-button-js.html
> +               fast/forms/mailto/formenctype-attribute-input-html.html
> +               fast/forms/mailto/formenctype-attribute-input-js.html

Looks obsolete.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.